Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylelint-lsp: init at 2.0.0 #298407

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Mar 23, 2024

Description of changes

Closes #288406.
Depends on #290715 (I copied over the commits for now).

After a pnpm build, the dist folder will contain only js and ts files, but not binaries. That's why I make a shell script that will run the js file with node. It works, but is there a better way to do it?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 23, 2024
@gepbird gepbird added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Mar 23, 2024
@SuperSandro2000
Copy link
Member

Depends on #290715 (I copied over the commits for now).

That got merged, please rebase

@gepbird gepbird force-pushed the stylelint-lsp-init branch from 672b6b3 to 360fecb Compare June 6, 2024 12:12
@gepbird gepbird removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Jun 6, 2024
@gepbird gepbird marked this pull request as ready for review June 6, 2024 12:13
@SuperSandro2000 SuperSandro2000 merged commit ec13fea into NixOS:master Jun 25, 2024
32 checks passed
@gepbird gepbird deleted the stylelint-lsp-init branch June 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: stylelint-lsp
2 participants